|
|
|
|
|
|
|
|
|
|
xen-devel
Re: [Xen-devel] [PATCH 2 of 3] Enable UEFI BIOS(OVMF) support in Xen-uns
To: |
Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx> |
Subject: |
Re: [Xen-devel] [PATCH 2 of 3] Enable UEFI BIOS(OVMF) support in Xen-unstable HVM |
From: |
Keir Fraser <keir@xxxxxxx> |
Date: |
Tue, 09 Aug 2011 11:03:37 +0100 |
Cc: |
Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, "edk2-devel@xxxxxxxxxxxxxxxxxxxxx" <edk2-devel@xxxxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Andrei Warkentin <andreiw@xxxxxxxxxxxx>, Jordan Justen <jljusten@xxxxxxxxx>, Bei Guan <gbtju85@xxxxxxxxx> |
Delivery-date: |
Tue, 09 Aug 2011 03:06:56 -0700 |
Dkim-signature: |
v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=1Z/AKpBY+8ITHCq3Naviv8CYMcvYjtwPypOKdbJ/GsI=; b=hd4XOWZKsSsMqYnG6GnccjRdouWXPMObzLixvSC5jC3o59v0xos4K0pODJsVQD1Z/l v9BWTh1XsQwU+UuzhPMZWMZBtAeZAxIjXqM2vMIyj2ek3GhMdLXoXJco9qtArrXhcDxE 0KdD7Nam75rBLvhml9c+LuRhwDyFc4jI1ltLA= |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<1312883891.26263.66.camel@xxxxxxxxxxxxxxxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Thread-index: |
AcxWe5sZOJBizj8IfEuImfPkLnK/3w== |
Thread-topic: |
[Xen-devel] [PATCH 2 of 3] Enable UEFI BIOS(OVMF) support in Xen-unstable HVM |
User-agent: |
Microsoft-Entourage/12.30.0.110427 |
On 09/08/2011 10:58, "Ian Campbell" <Ian.Campbell@xxxxxxxxxxxxx> wrote:
>> Apart from the pci_setup hook I just emailed about, hopefully we can avoid
>> code duplication in the init_vm86_tss hook as well. I'm not sure why we even
>> need the hook -- I'll need to check what it's for with Ian Campbell (cc'ed).
>
> I dunno ;-) I had assumed it was a rombios specific thing when I
> refactored for SeaBIOS (which doesn't implement the hook).
>
> Thinking about it again is this VM86 TSS a hangover from the days where
> we used to "emulate" realmode using vm86 in the HVM guest context (IIRC
> that was called vmxassist?). Perhaps the hook can be simply dropped?
No, as you correctly surmised it is for Tim's
realmode-emulation-acceleration. It is applicable to all guests regardless
of BIOS. Shall I move it back out into common code in hvmloader.c, then?
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|