WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2 of 3] Remove oxenstored's dependency on the log

To: Zheng Li <zheng.li@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2 of 3] Remove oxenstored's dependency on the log library of xapi-libs
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Tue, 9 Aug 2011 09:37:46 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 09 Aug 2011 01:38:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <6cb432bc2d1d73d30931.1312102745@eta>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1312102743@eta> <6cb432bc2d1d73d30931.1312102745@eta>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sun, 2011-07-31 at 09:59 +0100, Zheng Li wrote:
> ... by consolidating some of the functions with its own logging facility.
> 
> Signed-off-by: Zheng Li <zheng.li@xxxxxxxxxxxxx>
> 
> 
> ----
> diff --git a/tools/ocaml/xenstored/Makefile b/tools/ocaml/xenstored/Makefile
> --- a/tools/ocaml/xenstored/Makefile
> +++ b/tools/ocaml/xenstored/Makefile
> @@ -3,9 +3,7 @@ OCAML_TOPLEVEL = $(CURDIR)/..
>  include $(OCAML_TOPLEVEL)/common.make
> 
>  OCAMLINCLUDE += \
> -       -I $(OCAML_TOPLEVEL)/libs/log \
>         -I $(OCAML_TOPLEVEL)/libs/xb \
> -       -I $(OCAML_TOPLEVEL)/libs/uuid \
>         -I $(OCAML_TOPLEVEL)/libs/mmap \
>         -I $(OCAML_TOPLEVEL)/libs/xc \
>         -I $(OCAML_TOPLEVEL)/libs/eventchn

Since patch 1/3 removes these two libraries while the users are only
removed in patch 2/3 this series will introduces changesets where the
build is broken and hence break bisection. Please move this patch before
the library removal e.g. remove the libraries only after the users are
gone. The tree should continue to build (and work) after each individual
patch.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] [PATCH 2 of 3] Remove oxenstored's dependency on the log library of xapi-libs, Ian Campbell <=