Re: [Xen-devel] [PATCH 1 of 3] Some recent updates on ocaml xapi-libs

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

> diff --git a/tools/ocaml/libs/eventchn/Makefile 
> b/tools/ocaml/libs/eventchn/Makefile
> --- a/tools/ocaml/libs/eventchn/Makefile
> +++ b/tools/ocaml/libs/eventchn/Makefile
> @@ -7,6 +7,7 @@ CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_
>  OBJS = eventchn
>  INTF = $(foreach obj, $(OBJS),$(obj).cmi)
>  LIBS = eventchn.cma eventchn.cmxa
> +LIBS_eventchn = -L$(XEN_ROOT)/tools/libxc -lxenctrl
> 
>  LIBS_evtchn = $(LDLIBS_libxenctrl)

What is the difference between evtchn and eventchn here? Or is evtchn
redundant/incorrect?

You should use $(LDLIBS_foo) not open-coding the -L and -l options.
Perhaps all this change really needs to do is
s/LIBS_evtchn/LIBS_eventchn/ rather than adding the new line?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel