WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xenbackendd: clean variable in loop

Roger Pau Monné writes ("Re: [Xen-devel] [PATCH] xenbackendd: clean variable in 
loop"):
> The problem is that console usually comes after vbd, and it executes
> the block hotplug script with the console device (because 'type' is
> still set from the previous loop), nothing bad happens, just wanted to
> get rid of the error message. Since the variable is reused trough the
> for loop, I think it's best to clean it at the start/end of the loop,
> this makes the code easier to understand (for me). Where do you
> exactly suggest to put the initialization?

I would delete the initialisation (but not the whole declaration) from
line 155 and add it near line 274.  If this produces a compiler
warning about possible uninitialised use then we have missed
something.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel