Re: [Xen-devel] [PATCH] xenbackendd: clean variable in loop

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monné writes ("[Xen-devel] [PATCH] xenbackendd: clean variable in 
loop"):
> Fixed a cleanup of a variable used in a loop that was giving error
> messages, and added a debug message.

Thanks, but I'm not entirely clear about the bug you think this is
fixing.

Looking at the existing code it seems like the problem is that if the
loop is repeated and the 2nd device isn't a vbd or a vif, the previous
type is erroneously reused.

I think this woudl be better fixed by moving the initialisation of
type from the top of the function to just before it might first be
set.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel