| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH] X86: Fix a little mca bug
|
To: |
"Liu, Jinsong" <jinsong.liu@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH] X86: Fix a little mca bug |
|
From: |
Keir Fraser <keir@xxxxxxx> |
|
Date: |
Fri, 20 May 2011 09:10:18 +0100 |
|
Cc: |
"Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, "Dong, Eddie" <eddie.dong@xxxxxxxxx>, "Li, Xin" <xin.li@xxxxxxxxx> |
|
Delivery-date: |
Fri, 20 May 2011 01:11:22 -0700 |
|
Dkim-signature: |
v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to:cc :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=ZoFd0ZMJJlpcx4wJhopO7v3PRJVSCuHnOP35R8t5hZM=; b=YcNYudEfIRv/KywXxMw3OJIQRtefUNAWqoOsivGyy51I20aVQ2/jk/10UWk2k/v3/0 13k2Xz5BFziAV7Ce9LA3jmvsMovneTwwih1URzNphfPzg1/bGtA4JoBJR5/940TX3NHk /DI4SjVtpCNTj5DLTjJcYi1HsKW8TdFTIux48= |
|
Domainkey-signature: |
a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=WJ6LO96EEO9QiCvK4poUYrR4CYprlXkEbxDFCH/lg3ar4akALKdhDYUccyAoRCAZAo 3v6b/atTDjhDwFhb3u0bPz3GKPnMYeeHe3YEED4Da00JAVZe8YVEr6jYH3SCBM184edb fGSN4fp9DGaszC97cS7bkdCXAQZheHfTNRryk= |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<BC00F5384FCFC9499AF06F92E8B78A9E2083B2EDEA@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
AcwWHMbSu4Vbu56/T0OzJPao3EvrrgAqJRO+ |
|
Thread-topic: |
[PATCH] X86: Fix a little mca bug |
|
User-agent: |
Microsoft-Entourage/12.29.0.110113 |
On 19/05/2011 13:03, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
> X86: Fix a little mca bug
>
> At x86_mcinfo_dump(), a little bug at printk information, illusively
> indicate an CMCI/POLLED error to a MCE error, this will make debug confusing.
Is it correct to have entirely removed the final else clause?
-- Keir
> Signed-off-by: Liu, Jinsong <jinsong.liu@xxxxxxxxx>
>
> diff -r 2fe45768d2c1 xen/arch/x86/cpu/mcheck/mce.c
> --- a/xen/arch/x86/cpu/mcheck/mce.c Tue May 10 13:58:21 2011 +0800
> +++ b/xen/arch/x86/cpu/mcheck/mce.c Thu May 19 15:10:07 2011 +0800
> @@ -944,10 +944,11 @@ void x86_mcinfo_dump(struct mc_info *mi)
> printk(XENLOG_WARNING
> "CPU%d: Machine Check Exception: %16"PRIx64"\n",
> mc_global->mc_coreid, mc_global->mc_gstatus);
> - } else {
> - printk(XENLOG_WARNING "MCE: The hardware reports a non "
> - "fatal, correctable incident occurred on "
> - "CPU %d.\n",
> + } else if (mc_global->mc_flags & MC_FLAG_CMCI) {
> + printk(XENLOG_WARNING "CMCI occurred on CPU %d.\n",
> + mc_global->mc_coreid);
> + } else if (mc_global->mc_flags & MC_FLAG_POLLED) {
> + printk(XENLOG_WARNING "POLLED occurred on CPU %d.\n",
> mc_global->mc_coreid);
> }
>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home