Re: [Xen-devel] [PATCH] nestedsvm: ns_vmcb -> vvmcb

To:	Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] nestedsvm: ns_vmcb -> vvmcb
From:	Keir Fraser <keir@xxxxxxx>
Date:	Fri, 20 May 2011 08:57:34 +0100
Cc:
Delivery-date:	Fri, 20 May 2011 00:59:06 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=mkKs3d2SDenh9aGaiTc6jwjuLOo2yyf155yjRvO3AFM=; b=PJuaADaXYJfipJnWaLs98C0QyTFVroKgPGLgPeMimuzctUeXjouiWZI8ZV7OXE9bVP Jw7yKl/Dqcm4Ww9Or52DajGopZCE0yOzy25A9AuiU9e2+DREKdjeURa4+QhJEvC1+k+0 lx2AF69sRPsCJsKMiv6BsasHcRG8iX+sbgKxs=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=XZ1GYmC6OCTw0JBZR+PwayQC4xJpFsbZZyJcdcUwf3MZFUiQYkS7vBjXvAn9SFvUKV F/lYbVmefBWvQwyibR7bYcLYg8HosT6996YwFIH/BuIvFR8QMvSfWF6DzRlyf0Pr20mh GwpyXK+sckzEEpbyjxMBez/W81gluZMPmejPg=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4DD393D9.70605@xxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcwWw5O9VJueQkPrPkWDoYvNkmvyiQ==
Thread-topic:	[Xen-devel] [PATCH] nestedsvm: ns_vmcb -> vvmcb
User-agent:	Microsoft-Entourage/12.29.0.110113

On 18/05/2011 10:39, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> 
> Rename the virtual vmcb from ns_vmcb to vvmcb to
> make it easier for the reader what is meant.

I don't think vvmcb is a good idea. It's too close to vmcb. I think the
current name is actually okay, at least it is clearly distinct from anything
else. And you use the ns_ prefix quite consistently everywhere -- just
switching this one name would be weird.

 -- Keir

> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] nestedsvm: ns_vmcb -> vvmcb