Re: [Xen-devel] [PATCH 27 of 45] gcc-4.6 compile fix: xen/arch/x86/acpi/cpu_idle.c

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 19.05.11 at 21:05, Olaf Hering <olaf@xxxxxxxxx> wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@xxxxxxxxx>
> # Date 1305824412 -7200
> # Node ID 90160f32dbae6535e54e72375b004c0113ed1f62
> # Parent  c8f5b4743f9a91dc1e879d35f8f2d4b981f0963d
> gcc-4.6 compile fix: xen/arch/x86/acpi/cpu_idle.c
> 
> cpu_idle.c: In function 'acpi_idle_do_entry':
> cpu_idle.c:276:9: error: variable 'unused' set but not used 
> [-Werror=unused-but-set-variable]
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> 
> diff -r c8f5b4743f9a -r 90160f32dbae xen/arch/x86/acpi/cpu_idle.c
> --- a/xen/arch/x86/acpi/cpu_idle.c    Thu May 19 19:00:11 2011 +0200
> +++ b/xen/arch/x86/acpi/cpu_idle.c    Thu May 19 19:00:12 2011 +0200
> @@ -273,7 +273,7 @@ static void acpi_processor_ffh_cstate_en
>  
>  static void acpi_idle_do_entry(struct acpi_processor_cx *cx)
>  {
> -    int unused;
> +    int unused __attribute__((unused));

Better remove the variable and its assignment - inl(), just as the
inb() immediately before, can't be removed by the compiler even
if its result is unused (they're volatile asm()-s).

Jan

>  
>      switch ( cx->entry_method )
>      {
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx 
> http://lists.xensource.com/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel