WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Fwd:[PATCH-may be a bug ignored] tools/libxl/libxl__buil

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Fwd:[PATCH-may be a bug ignored] tools/libxl/libxl__build_device_model_args_new/old: The condition is so rigorous that user has no chance to disable the vnc
From: ZhouPeng <zpengxen@xxxxxxxxx>
Date: Tue, 10 May 2011 19:09:32 +0800
Cc: "Xen-Devel \(E-mail\)" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Tue, 10 May 2011 04:11:49 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=QnPGjqaJhh+nKMk2o0OhaU6g0qmH6GYjppqT1TFVxV0=; b=aBeVXI/mJmNkTPXqi82mnCmhAlBGlglF2QfKH7l8p4dqPeaZ1V0GBQuth6Zzf1VtaZ VOsNIIjV+VlHwrCZIYTT75zwD958yYHexklGEkPScXLKG121vUFuofNgv2xMYjgHX5GX eI2r91aj4l5AnmJZL8APuYKpz1ZtvN92iKMA4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=s3IJTvBJUDKkrj/XVr2IFoijMyuTjhR8sREwr10z48yqCIq5N3MhpouGbo0JESSe8J lW+PXDquZmuvOzSG7yix0Ge86kujbXZkuqRwtHIFe46MqwXY6HY4T0uxhYHhSAz4qsr7 G8wXmaoPFTCJzBeJzpG0b8lSu8IotYvPKP5UE=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <BANLkTikoKWZ3ckmp6FLRY5jncJ9TeBC2Rw@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BANLkTi=nXQ7m4+2MrNkPR64073X1J=Ti3Q@xxxxxxxxxxxxxx> <19911.57349.743943.518422@xxxxxxxxxxxxxxxxxxxxxxxx> <BANLkTikoKWZ3ckmp6FLRY5jncJ9TeBC2Rw@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
2011/5/10 ZhouPeng <zpengxen@xxxxxxxxx>:
> 2011/5/9 Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>:
>> ZhouPeng writes ("[Xen-devel] Fwd:[PATCH-may be a bug ignored] 
>> tools/libxl/libxl__build_device_model_args_new/old: The condition is so 
>> rigorous that user has no chance to disable the vnc"):
>>> In my spice testing,
>>> I find user have no way to disable vnc in qemu-old and new using xl,
>>> no matter how to set
>>> "vnc vncunused vncpasswd vncdisplay vnclisten" in vm cfg file.
>>
>> Does your patch not have the effect of turning vnc off by default ?  I
>> don't think that's correct.
>
> pls see below:
> parse_config_data(...)  < xl_cmdimpl.c >
>       libxl_init_dm_info(...) set dm_info->vnc = 1
>       ...
>       if (!xlu_cfg_get_long(config, "vnc", &l))
>                dm_info->vnc = l
>
> So, The patch will not turn vnc off  by default,
So, The patch will not turn vnc off  by default. ...typo mistake :)
> Because dm_info->vnc = 1 in libxl_init_dm_info(...) turn on vnc in default,
> My patch turns off vnc only when user 'set vnc = 0' explicitly in vm cfg file.
>
> And testing in xen-unstable, it works.
>
> Thanks,
>> Ian.
>>
>
>
>
> --
> Zhou Peng
> Operating System Technology Group
> Institute of Software, the Chinese Academy of Sciences (ISCAS)
>



-- 
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel