WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH]tools/libxl: fix a bug in libxl__build_device_mod

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH]tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vncpasswd can't be empty if info->vncpasswd != NULL
From: ZhouPeng <zpengxen@xxxxxxxxx>
Date: Fri, 15 Apr 2011 17:53:32 +0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "ian.campbell@xxxxxxxxxx" <ian.campbell@xxxxxxxxxx>
Delivery-date: Fri, 15 Apr 2011 02:54:15 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=cwtV+GAAiB5grXg/qhRM9NM/NoRWZUongWwFGBGEvZQ=; b=gy0FB5FAQoKkFzI8HZQzyVhwbx+LED+lIewnSVkSw9CSqj6p89xaSmQZ05AYOkNml0 7aMzi8KUo9A0S9Cg9qk4iRpc+s6YxmAQ7vBg2FPDWI+HC69V2mgwpd3nUa0AO0zqH2yI yk/djFDGAssX+pAPJjmdx9dgDPcHHs+E2zFxs=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=tlU4QYVWWvq2VqsWQWTX50R7mBtb8DHXxScpI34UokJmFf5zoYUgMawHrbwGI/aOb/ x/Hk7+Yafa7aoKrNKUm6z0ibBLRfL8CGKdYLJJWKHlKmM7T1cldd2uOHbPVDOQ1qmskO dV1ZDQM9K/YJ7DDnILED8W5YPLB+x+gB+KZqY=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DA811F5.3080106@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BANLkTikOiFNm5OM+JFtpW6_32zTtpcUQYA@xxxxxxxxxxxxxx> <4DA801C4.5060102@xxxxxxx> <BANLkTikKZOOfstWHCu_iD_JxsBmjx8HsxA@xxxxxxxxxxxxxx> <4DA811F5.3080106@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx


2011/4/15 Christoph Egger <Christoph.Egger@xxxxxxx>
On 04/15/11 11:36, ZhouPeng wrote:


2011/4/15 Christoph Egger<Christoph.Egger@xxxxxxx<mailto:Christoph.Egger@xxxxxxx>>

On 04/15/11 10:33, ZhouPeng wrote:
Signed-off-by: Zhou Peng<zhoupeng@xxxxxxxxxxxxxxx<mailto:zhoupeng@xxxxxxxxxxxxxxx>>


tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vncpasswd can't be empty if info->vncpasswd != NULL


NACK!  This can info->vncpasswd[0] contains '\0' if you have


  vncpasswd=''

in the guest config file.

 " if (info->vncpasswd&&   info->vncpasswd[0]) “ can
  vncpasswd='' in guest cfg file, when using upstream-qemu-xen
  and block vncpasswd='passwd'
  Can it be reasonable?



Does that mean upstream qemu-xen and in-tree qemu-xen behave differently?
  if (new_qemu == 1) {
        return libxl__build_device_model_args_new(gc, info, disks, num_disks, vifs, num_vifs);
    } else {
        return libxl__build_device_model_args_old(gc, info, disks, num_disks, vifs, num_vifs);
    }
 
Christoph



--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632




--
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel