Re: [Xen-devel] [PATCH]tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vncpasswd can't be empty if info->vncpasswd != NULL

[ZhouPeng <zpengxen@xxxxxxxxx>]

2011/4/15 Christoph Egger <Christoph.Egger@xxxxxxx>

On 04/15/11 11:36, ZhouPeng wrote:

2011/4/15 Christoph Egger<Christoph.Egger@xxxxxxx<mailto:Christoph.Egger@xxxxxxx>>

On 04/15/11 10:33, ZhouPeng wrote:

Signed-off-by: Zhou Peng<zhoupeng@xxxxxxxxxxxxxxx<mailto:zhoupeng@xxxxxxxxxxxxxxx>>

tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vncpasswd can't be empty if info->vncpasswd != NULL


NACK!  This can info->vncpasswd[0] contains '\0' if you have


  vncpasswd=''

in the guest config file.

 " if (info->vncpasswd&&   info->vncpasswd[0]) “ can
  vncpasswd='' in guest cfg file, when using upstream-qemu-xen
  and block vncpasswd='passwd'
  Can it be reasonable?

Does that mean upstream qemu-xen and in-tree qemu-xen behave differently?

  if (new_qemu == 1) {
        return libxl__build_device_model_args_new(gc, info, disks, num_disks, vifs, num_vifs);
    } else {
        return libxl__build_device_model_args_old(gc, info, disks, num_disks, vifs, num_vifs);
    }
 

Christoph

--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

-- 
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel