WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH]tools/libxl: fix a bug in libxl__build_device_mod

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH]tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vncpasswd can't be empty if info->vncpasswd != NULL
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Fri, 15 Apr 2011 09:42:02 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 15 Apr 2011 01:43:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DA801C4.5060102@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <BANLkTikOiFNm5OM+JFtpW6_32zTtpcUQYA@xxxxxxxxxxxxxx> <4DA801C4.5060102@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2011-04-15 at 09:28 +0100, Christoph Egger wrote:
> On 04/15/11 10:33, ZhouPeng wrote:
> > Signed-off-by: Zhou Peng<zhoupeng@xxxxxxxxxxxxxxx>
> >
> > tools/libxl: fix a bug in libxl__build_device_model_args_new. 
> > info->vncpasswd can't be empty if info->vncpasswd != NULL
> >
> 
> NACK!  This can info->vncpasswd[0] contains '\0' if you have
> 
> 
>     vncpasswd=''
> 
> in the guest config file.

perhaps a strcmp(...., "") might make this more obvious to the casual
reader?

> 
> Christoph
> 
> 
> > diff -r 3f00c5faa12a tools/libxl/libxl_dm.c
> > --- a/tools/libxl/libxl_dm.c    Wed Apr 13 16:10:26 2011 +0100
> > +++ b/tools/libxl/libxl_dm.c    Fri Apr 15 09:45:43 2011 +0800
> > @@ -209,7 +209,7 @@ static char ** libxl__build_device_model
> >           int display = 0;
> >           const char *listen = "127.0.0.1";
> >
> > -        if (info->vncpasswd&&  info->vncpasswd[0]) {
> > +        if (info->vncpasswd&&  !info->vncpasswd[0]) {
> >               assert(!"missing code for supplying vnc password to qemu");
> >           }
> >           flexarray_append(dm_args, "-vnc");
> >
> > --
> > Zhou Peng
> > Operating System Technology Group
> > Institute of Software, the Chinese Academy of Sciences (ISCAS)
> > <mailto:ailvpeng25@xxxxxxxxx>
> >
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel