|   | 
      | 
  
  
      | 
      | 
  
 
     | 
    | 
  
  
     | 
    | 
  
  
    |   | 
      | 
  
  
    | 
         
xen-devel
[Xen-devel] Re: [RFC PATCH V4 1/5] cpuidle: Remove pm_idle pointer	for x
 
| 
To:  | 
Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> | 
 
| 
Subject:  | 
[Xen-devel] Re: [RFC PATCH V4 1/5] cpuidle: Remove pm_idle pointer	for x86 | 
 
| 
From:  | 
Trinabh Gupta <trinabh@xxxxxxxxxxxxxxxxxx> | 
 
| 
Date:  | 
Wed, 23 Mar 2011 15:40:48 +0530 | 
 
| 
Cc:  | 
venki@xxxxxxxxxx, ak@xxxxxxxxxxxxxxx, suresh.b.siddha@xxxxxxxxx,	peterz@xxxxxxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx,	linux-kernel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx,	arjan@xxxxxxxxxxxxxxx, lenb@xxxxxxxxxx | 
 
| 
Delivery-date:  | 
Thu, 24 Mar 2011 17:04:00 -0700 | 
 
| 
Envelope-to:  | 
www-data@xxxxxxxxxxxxxxxxxxx | 
 
| 
In-reply-to:  | 
<20110323120044.bb8c0ae1.sfr@xxxxxxxxxxxxxxxx> | 
 
| 
List-help:  | 
<mailto:xen-devel-request@lists.xensource.com?subject=help> | 
 
| 
List-id:  | 
Xen developer discussion <xen-devel.lists.xensource.com> | 
 
| 
List-post:  | 
<mailto:xen-devel@lists.xensource.com> | 
 
| 
List-subscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> | 
 
| 
List-unsubscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> | 
 
| 
References:  | 
<20110322123208.28725.30945.stgit@xxxxxxxxxxxxxxxxxxx>	<20110322123223.28725.21929.stgit@xxxxxxxxxxxxxxxxxxx>	<20110323120044.bb8c0ae1.sfr@xxxxxxxxxxxxxxxx> | 
 
| 
Sender:  | 
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx | 
 
| 
User-agent:  | 
Mozilla/5.0 (X11; U; Linux i686; en-US;	rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc11 Thunderbird/3.0.5 | 
 
 
 
Hi Stephen,
On 03/23/2011 06:30 AM, Stephen Rothwell wrote:
 
Hi,
Just some simple comments.
Does having this patch first in the series break APM idle?
 
 
Thanks for reviewing.
Yes, I think removal of "pm_idle = default_idle" statement in
APM may have to be moved here.
 
On Tue, 22 Mar 2011 18:02:27 +0530 Trinabh Gupta<trinabh@xxxxxxxxxxxxxxxxxx>  
wrote:
 
diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c
index 8d12878..17b7101 100644
--- a/arch/x86/kernel/process_32.c
+++ b/arch/x86/kernel/process_32.c
@@ -74,6 +74,8 @@ static inline void play_dead(void)
  }
  #endif
+extern void cpuidle_idle_call(void);
 
 
Put this declaration in a header file and include that header file here
and in the file that defines that function.
 
 
Ok, thanks
-Trinabh
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 
 |   
 
| <Prev in Thread] | 
Current Thread | 
[Next in Thread> |  
- [Xen-devel] Re: [RFC PATCH V4 1/5] cpuidle: Remove pm_idle pointer	for x86,
Trinabh Gupta <=
  
 |  
  
 | 
    | 
  
  
    |   | 
    |