[Xen-devel] Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_

On Wed, 2011-03-23 at 16:57 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 25 of 30] libxl: move 
> libxl_doimid_valid_guest out of line"):
> > Why should it be inline?
> 
> In general, I think it's fine to have trivial operations like this
> inlined.  Things which one would otherwise maybe use a macro for.
> 
> > What actually led to the changes was that a subsequent patch removed the
> > indirect dependency which defined DOMID_FIRST_RESERVED. Rather than
> > finding and adding the appropriate xen header to libxl.h (which is a
> > valid option) I decided that the function shouldn't have been inline in
> > the first place...
> 
> I think it's fine to import Xen headers into libxl.h.

In any case whatever it was which caused me to do this is not present in
the final series I ended up sending and neither this patch nor any
additional #includes are required AFAICT.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

[Xen-devel] [PATCH] tools: ocaml: do not try to link dynamic objects into .a libraries, Ian Campbell

Next by Date:

[Xen-devel] [PATCH] libxl: export libxl_utils.h, Ian Jackson

Previous by Thread:

[Xen-devel] Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest out of line, Ian Jackson

Next by Thread:

[Xen-devel] Re: [PATCH 28 of 30] libxl: do not expose libxenctrl/libxenstore headers via libxl.h, Ian Jackson

Indexes:

[Date] [Thread] [Top] [All Lists]