[Xen-devel] Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest out of line

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest 
out of line"):
> Why should it be inline?

In general, I think it's fine to have trivial operations like this
inlined.  Things which one would otherwise maybe use a macro for.

> What actually led to the changes was that a subsequent patch removed the
> indirect dependency which defined DOMID_FIRST_RESERVED. Rather than
> finding and adding the appropriate xen header to libxl.h (which is a
> valid option) I decided that the function shouldn't have been inline in
> the first place...

I think it's fine to import Xen headers into libxl.h.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel