Re: [Xen-devel] xen-unstable: build fails

To:	Jan Beulich <JBeulich@xxxxxxxxxx>
Subject:	Re: [Xen-devel] xen-unstable: build fails
From:	Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date:	Thu, 17 Mar 2011 11:29:04 +0100
Cc:	Keir Fraser <keir.xen@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Thu, 17 Mar 2011 03:29:47 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1300357747; x=1331893747; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; bh=dX/ORimv0JegzOUYe/lnZz2SmlL+YbpD6iFfX5aqvik=; b=rMDxwsE8bUevBHq404igHZCUkoDTpqiz2rK0WnEnCE+FGIVEcy+Vm6Ky Wz1Ko1kjhD4hcGit0USVEr2cosUF+McGvbk6nsNvsn3Qyuh0J7lGWjJ1D W7INzd6GvyTgV5nl8K3Zey7tk/IadflUpVCvAg11IljFTj/fTL43oqdTE e6u/x+eWQkS6ATzL62bnwWnUHPONwcQxOO2XTltU75qCeVQjj+lrStyKz +KAkEWjHFZ6vbTsxmHComzI2wJOE5;
Domainkey-signature:	s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Xfry5aRNgUnyMT9fm8c5KGcbmmmZFAVxjEL5VAB5N2sNWem8vpfuIU7E BTSiSJRb8G6W6ymgZnfETlDLmZeRxeUZiFKnB/a4OhKYgRWP9X/C5OaPd Ly73++cMroC2NQw0ljA+jec9SZEDzpIOapzt08qRJBgM9fJUNH86QwWxS g30YSXDs6fWZHr/H7MDx46yFTo/qoftJskFv3CKPPYLjXFa1SSOm1Vsmg Lx+8fl5IomOv7QbZkcNCS9HKlvNWj;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4D81ECC1020000780003705D@xxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Fujitsu Technology Solutions
References:	<C9A772CD.14F43%keir.xen@xxxxxxxxx> <4D81CD8A.9050601@xxxxxxxxxxxxxx> <4D81ECC1020000780003705D@xxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20101226 Iceowl/1.0b1 Icedove/3.0.11

On 03/17/11 11:13, Jan Beulich wrote:

On 17.03.11 at 09:59, Juergen Gross<juergen.gross@xxxxxxxxxxxxxx>  wrote:

The problem is still the relative XEN_ROOT specification.
Or the missing .config under XEN_ROOT, so creating this file solves my
problem. :-)


I'd favor the latter, e.g. by adding something like

cfg-create := $(shell touch $(XEN_ROOT)/.config)

to ./Config.mk, or putting the include in a conditional instead
of making use of -include.


As short time measure this seems to be okay.

On the long run I'd prefer to use absolute paths only. Otherwise you've
always a risk to use something from outside the intended build environment.

XEN_ROOT = $(abspath ../..)

seems not too hard to use instead of

XEN_ROOT = ../..

And I'm still favoring usage of conditional setting of XEN_ROOT in included
Makefiles other than config/* to avoid hard to find problems.


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] xen-unstable: build fails