[Xen-devel] xen-unstable: build fails

To:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] xen-unstable: build fails
From:	Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date:	Wed, 16 Mar 2011 14:50:47 +0100
Delivery-date:	Wed, 16 Mar 2011 06:55:26 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1300283449; x=1331819449; h=message-id:date:from:mime-version:to:subject: content-transfer-encoding; bh=9Sh8MfX8v3qJEj7Xi1zFzhHqfyZ2bWqfBoTVsAXGUX0=; b=wBpVR3k5/7ThezWsPGC3Z58bVQKDtSG8C/X6t5ECuJ2L1cxTmGsnfZW5 nshddK43naVqLhTcvjY6GYPYO72u6T1Lq5ikLMt6zVwoEww68fFRNAmk7 h0/6MgEfwGoeLzGWJa0XDnOo9WpBull9XAncEDUgSHf27U+GwQdoAIjMk d3tZjC5Q4vjFfeRoNGeGmauOV767i9H5ZIII2KTBrT5jpgJg/milCJu7i vzdYtAq0zSFisz+BcfjTaUou+DD+I;
Domainkey-signature:	s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:Subject:Content-Type: Content-Transfer-Encoding; b=DoUtR6ueUAe/k/mva36ykQTwnTtZ/0RyGkdeho/w2pbknTi/S+ETNlLI fsln4ZjkfkPBbzlgF9l9W4yRsL8DjUzvutL0qOlGbSxu2LycCJFD1T02o wCvgFjDxN7F/xIAzVWD74MqvFBwn4CSfrxrhBlXkRxKmG4MUxu5OEBR16 lNBwHPd9GbnYYplS9YTu1VSfqTIZq7IIlyXU6zR1CSRXdAVH7MtqgSBGK pNsPZTMbBMBhkZv41tACvzcXOPOlL;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Fujitsu Technology Solutions
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20101226 Iceowl/1.0b1 Icedove/3.0.11

Hi,

I've just set up a machine with OpenSuse 11.4 and tried to build Xen.

Under root I did:

hg clone http://xenbits.xensource.com/xen-unstable.hg
cd xen-unstable.hg
make xen

The make failed with:

make[4]: Entering directory `/root/xen-unstable.hg/xen/arch/x86/boot'
RELOC=0x7c000 make -f build32.mk reloc.S
make[5]: Entering directory `/root/xen-unstable.hg/xen/arch/x86/boot'
make[5]: *** ../../../../.config: Is a directory.  Stop.
make[5]: Leaving directory `/root/xen-unstable.hg/xen/arch/x86/boot'
make[4]: *** [reloc.S] Error 2
make[4]: Leaving directory `/root/xen-unstable.hg/xen/arch/x86/boot'
make[3]: *** [/root/xen-unstable.hg/xen/arch/x86/boot/built_in.o] Error 2
make[3]: Leaving directory `/root/xen-unstable.hg/xen/arch/x86'
make[2]: *** [/root/xen-unstable.hg/xen/xen] Error 2
make[2]: Leaving directory `/root/xen-unstable.hg/xen'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/root/xen-unstable.hg/xen'
make: *** [install-xen] Error 2

The reason seems to be a directory /root/.config which isn't present on my
other machines.

make tools

fails in a similar way. Many Makefiles seem to contain lines like:

XEN_ROOT=../..

which is a really bad idea in my opinion. XEN_ROOT should only be set, if it
is not yet defined.

I'd suggest to use

XEN_ROOT ?= $(PWD)/../..

instead. A patch is easily made, but affects ca. 100 Makefiles. And this
change could break the possibility to just do a "make" in a subdirectory.

Opinions?


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] xen-unstable: build fails