WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] remove unneeded test for cpu in cpupool

To: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Przywara, Andre" <Andre.Przywara@xxxxxxx>
Subject: Re: [Xen-devel] [Patch] remove unneeded test for cpu in cpupool
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Wed, 16 Mar 2011 10:13:42 +0000
Cc:
Delivery-date: Wed, 16 Mar 2011 03:15:28 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=NPHRhll+m7ZpYhozYTfLDyGlY+Ih1mfm4mUJ/TM8WuA=; b=vbbQH34s5kIW6MycLzn7QZ6Q+IjnhBLp7gl6kNGFRZLXn9Vz7GAX1twwA9kjKyEMzD 2X5ozoEq8ymDSFvUcnYfkASomtn5Jn2Ayq55Ii10Fnb4IZtsKyO42GfHT1BxVhvdi/NV 3vCZdyBLXqx2tNRamckgXhL7qm2g+hdnMQ8vc=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=u/GC0cV9PQaYWD+eFrUoBG7Tsw6ka9yPfMZ2PE7KIePJyV/+OOwjpyQD4b9bot0qZR J+P4P8BTo/k0d0LHhK0//DDnlwtedZpWrrzYc6v/jjlz1QE4HTJj+vfT4RfMZlMp/vyM FFcDy/Xc1Z9iy3chiX3KtuDxgQmePy46/EWtQ=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D8059DD.20907@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcvjwtNlH0yWhetBG06wqhuYON9uQg==
Thread-topic: [Xen-devel] [Patch] remove unneeded test for cpu in cpupool
User-agent: Microsoft-Entourage/12.28.0.101117
On 16/03/2011 06:34, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxx> wrote:

> Hi,
> 
> attached patch removes an unneeded check in vcpu_migrate().
> 
> Andre, could you please give it a try on your 48 core machine with
> 
> xl cpupool-numa-split
> 
> I'd like to make sure the check is really not needed. On my machines it worked
> okay, but your machine seems to trigger races more easily.

Could you BUG_ON failing this test when we exit the retry loop? It seems a
suitable loop post-condition.

 -- Keir

> 
> Juergen



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>