| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [GIT/PATCH v5] xen network backend driver
|
To: |
Ben Hutchings <bhutchings@xxxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [GIT/PATCH v5] xen network backend driver |
|
From: |
Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx> |
|
Date: |
Tue, 15 Mar 2011 10:06:31 +0000 |
|
Cc: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, Michał Mirosław <mirqus@xxxxxxxxx>, Francois Romieu <romieu@xxxxxxxxxxxxx>, Stephen, Hemminger <shemminger@xxxxxxxxxx> |
|
Delivery-date: |
Tue, 15 Mar 2011 03:07:09 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1300128035.2584.6.camel@bwh-desktop> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Organization: |
Citrix Systems, Inc. |
|
References: |
<1300112879.17339.2162.camel@xxxxxxxxxxxxxxxxxxxxxx> <1300128035.2584.6.camel@bwh-desktop> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Mon, 2011-03-14 at 18:40 +0000, Ben Hutchings wrote:
> On Mon, 2011-03-14 at 14:27 +0000, Ian Campbell wrote:
> > The following patch is the fifth iteration of the Xen network backend
> > driver for upstream Linux.
> >
> > This driver ("netback") is the host side counterpart to the frontend
> > driver in drivers/net/xen-netfront.c. The PV protocol is also
> > implemented by frontend drivers in other OSes too, such as the BSDs and
> > even Windows.
> >
> > Changes since the fourth posting, due to review from Stephen Hemminger:
> > * Treat dev->features as u32 (it effectively is already and
> > becomes literally so in net-next -- there's no harm in netback
> > switching earlier)
> > * Use stats from struct netdevice instead of a local copy.
> [...]
>
> All looks good (or good enough) to me. I would add Reviewed-by, but
> this isn't a single patch.
Since David asked me to post as a single patch I've added your review by
to that. I hope that's ok.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home