WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] libxl: don't require vncpasswd when empty

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxl: don't require vncpasswd when empty
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Mon, 14 Feb 2011 15:58:31 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 14 Feb 2011 07:00:02 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19797.26511.246950.284932@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201102111108.05716.Christoph.Egger@xxxxxxx> <19797.26511.246950.284932@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.10
On Friday 11 February 2011 17:45:03 Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] libxl: don't require vncpasswd 
when empty"):
> > Attached patch fixes a regression introduced in c/s 22866:ed9ef3b07d2a:
> >
> > Don't require a NULL-byte password when the guest config file
> > has the entry
> >      vncpasswd=''
>
> I'm afraid I don't understand this patch.
>
> If you say "vncpasswd=''" in the config file then info->vncpasswd
> would be "" and therefore info->vncpasswd[0] would be '\0' so the
> branch would not be taken and you would end up without ",password" on 
> the qemu command line.  The result should be that qemu should not
> require a password.

I actually end up with ",password" on qemu command line because

    info->vncpasswd != info->vncpasswd[0] :-)

The command 'ps axuww | grep qemu' makes that visible.

> Is that not what you would intend with such a config statement ?
>
> Your patch seems to do the opposite of what you say it does.  It would
> seem to make qemu require an empty string as a password, which is
> daft.

Yes, qemu wants me to enter a NULL-byte as password.
With my patch, qemu doesn't ask me for a password at all.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>