 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] libxl: don't require vncpasswd when empty
| To: | Christoph Egger <Christoph.Egger@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] libxl: don't require vncpasswd when empty |
| From: | Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
| Date: | Fri, 11 Feb 2011 16:45:03 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Fri, 11 Feb 2011 08:45:44 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <201102111108.05716.Christoph.Egger@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Newsgroups: | chiark.mail.xen.devel |
| References: | <201102111108.05716.Christoph.Egger@xxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Christoph Egger writes ("[Xen-devel] [PATCH] libxl: don't require vncpasswd
when empty"):
> Attached patch fixes a regression introduced in c/s 22866:ed9ef3b07d2a:
>
> Don't require a NULL-byte password when the guest config file
> has the entry
> vncpasswd=''
I'm afraid I don't understand this patch.
If you say "vncpasswd=''" in the config file then info->vncpasswd
would be "" and therefore info->vncpasswd[0] would be '\0' so the
branch would not be taken and you would end up without ",password" on
the qemu command line. The result should be that qemu should not
require a password.
Is that not what you would intend with such a config statement ?
Your patch seems to do the opposite of what you say it does. It would
seem to make qemu require an empty string as a password, which is
daft.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH 5/5][RFC] lwp: adding support for AMD lightweight profiling, Wei Huang |
|---|---|
| Next by Date: | [Xen-devel] [PATCH 4/5][RFC] lwp: adding support for AMD lightweight profiling, Wei Huang |
| Previous by Thread: | [Xen-devel] [PATCH] libxl: don't require vncpasswd when empty, Christoph Egger |
| Next by Thread: | Re: [Xen-devel] [PATCH] libxl: don't require vncpasswd when empty, Christoph Egger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
