WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [xen-devel][PATCH 2/5] Xl interface change plus changes to code it i

To: Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx>
Subject: Re: [xen-devel][PATCH 2/5] Xl interface change plus changes to code it impacts
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Tue, 8 Feb 2011 19:09:41 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Tue, 08 Feb 2011 11:08:23 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D5193A5.9030508@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D50628A.2000307@xxxxxxxxx> <alpine.DEB.2.00.1102081542120.7277@kaball-desktop> <4D5193A5.9030508@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Tue, 8 Feb 2011, Kamala Narasimhan wrote:
> >> diff -r e4406b9fb064 tools/libxl/libxl_device.c
> >> --- a/tools/libxl/libxl_device.c   Mon Feb 07 15:04:32 2011 +0000
> >> +++ b/tools/libxl/libxl_device.c   Mon Feb 07 11:28:10 2011 -0500
> >> @@ -121,31 +121,24 @@ out:
> >>      return rc;
> >>  }
> >>  
> >> -char *libxl__device_disk_string_of_phystype(libxl_disk_phystype phystype)
> >> +char *libxl__device_disk_string_of_format(libxl_disk_format format)
> >>  {
> >> -    switch (phystype) {
> >> -        case PHYSTYPE_QCOW: return "qcow";
> >> -        case PHYSTYPE_QCOW2: return "qcow2";
> >> -        case PHYSTYPE_VHD: return "vhd";
> >> -        case PHYSTYPE_AIO: return "aio";
> >> -        case PHYSTYPE_FILE: return "file";
> >> -        case PHYSTYPE_PHY: return "phy";
> >> -        case PHYSTYPE_EMPTY: return "file";
> >> -        default: return NULL;
> >> +    switch (format) {
> >> +        case DISK_FORMAT_QCOW: return "qcow";
> >> +        case DISK_FORMAT_QCOW2: return "qcow2"; 
> >> +        case DISK_FORMAT_VHD: return "vhd"; 
> >> +        case DISK_FORMAT_RAW:
> >> +        case DISK_FORMAT_EMPTY: return "file"; 
> > 
> > This should be return "aio".
> >
> When I tested, both "aio" and "file" worked and I went with "file".  But if it
> is better to go with "aio", I will do that.

qemu doesn't work with "file", it works with "aio" or "raw" ("raw" would
be better but I don't think tapdisk2 supports it).

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel