Re: [xen-devel][PATCH 2/5] Xl interface change plus changes to code it impacts

[Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx>]

Ian Campbell wrote:
> On Mon, 2011-02-07 at 21:22 +0000, Kamala Narasimhan wrote:
>> Attached are the changes made to xl disk related interface per earlier 
>> discussion.  Please let me know if there are further comments/issues to fix.
> 
> Please can you include a full/standalone commit message describing the
> change and the reasons for it etc, The reference to "earlier discussion"
> is likely to be lost with time.
>
Sure, will do when I send out a revised patch that addresses review comments.

> Did we decide to leave DISK_BACKEND_DEFAULT (i.e. libxl chooses based on
> the image type, host's backend support etc) for 4.2? I don't mind if we
> did but does that make "block-dev-type" as described in patch 1/5
> non-optional? (and therefore not really deprecated)
> 
block-dev-type is still optional.  Patch 5/5, the validation patch will take
care of the case when that optional attribute is not provided but the patches
submitted so far should have stop gap code that sets a fallback value.

Kamala



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel