Re: [Xen-devel] [memory sharing] bug on get_page_and_type

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 10:49 +0000 on 31 Jan (1296470977), George Dunlap wrote:
> Xiaoyun,
> 
> Thanks for all of your work getting page sharing working.  When
> submitting patches, please break them down into individual chunks,
> each of which does one thing.  Each patch should also include a
> comment saying what the patch does and why, and a Signed-off-by line
> indicating that you certify that the copyright holder (possibly you)
> is placing the code under the GPL.

Also: we don't usually take patches against the testing tree; you should
rebase them against xen-unstable and when they have been applied there
you can ask for them to be backported to xen 4.0-testing.  (Otherwise
all the bugs would re-appear in 4.1!)  Some of the changes you sent here
have already been applied to xen-unstable.

I haven't read the patches in detail but they need a bit of tidying up -
e.g. you add some commented-out code.  Please clean them up before
resubmitting.

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel