WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: Avoid alloc for xsave before xsave_init

To: "Wei, Gang" <gang.wei@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] RE: Avoid alloc for xsave before xsave_init
From: "Huang2, Wei" <Wei.Huang2@xxxxxxx>
Date: Thu, 13 Jan 2011 14:21:52 -0600
Accept-language: en-US
Acceptlanguage: en-US
Cc: Keir Fraser <keir@xxxxxxx>
Delivery-date: Thu, 13 Jan 2011 12:24:54 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <F26D193E20BBDC42A43B611D1BDEDE7125198A82D9@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <F26D193E20BBDC42A43B611D1BDEDE7125198A82D9@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcuzUojLeS2z6tQSQCO88b+hMX2tAQAC+pjA
Thread-topic: Avoid alloc for xsave before xsave_init
Hi Gang,

Was the issue caused by the uninitialized variable xsave_cntxt_size, triggering 
problem for _xmalloc()? If so, one solution is to set xsave_cntxt_size=576 (the 
default value after reset) as a default value. When xsave_alloc_save_area() is 
called for idel VCPU, _xmalloc() will initialize 576 bytes. Idle domain doesn't 
change xcr0 from my understanding. So its xcr0 is XSTATE_FP_SSE all the time. 

Best,
-Wei

-----Original Message-----
From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Wei, Gang
Sent: Thursday, January 13, 2011 12:49 PM
To: xen-devel@xxxxxxxxxxxxxxxxxxx
Cc: Keir Fraser; Wei, Gang
Subject: [Xen-devel] Avoid alloc for xsave before xsave_init

While debugging some weird booting failure bugs, just found currently, 
xsave_alloc_save_area will be called in 
init_idle_domain->scheduler_init->alloc_vcpu->vcpu_initialise calls, it is 
earlier than xsave_init called in identity_cpu(). This may causing buffer 
overflow on xmem_pool. I am thinking about how to fix it.

Jimmy

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel