[Xen-devel] Re: xen boot crash

[Olaf Hering <olaf@xxxxxxxxx>]

On Wed, Jan 12, Olaf Hering wrote:

> On Wed, Jan 12, Christoph Egger wrote:
> 
> > 
> > Hi!
> > 
> > Changeset 22706:ca10302ac285  causes below boot crash.
> > Reverting it makes xen boot again.
> > 
> > The rip points to xen/common/page_alloc.c:543
> 
> Yes, that change was not well done. Sorry for that. I'm sure it doesnt
> crash if set_gpfn_from_mfn() is called from free_domheap_pages().
> 
> Looking at free_heap_pages(), now the page owner is cleared at the
> beginning of the loop. But later in the loop it is checked wether a TLB
> flush is required. So the set_gpfn_from_mfn() should be at least moved
> past this check. Even if that doesnt fix the crash you are seening.
> 
> I will see if I can come up with a better version.

It crashes in end_boot_allocator -> init_heap_pages -> free_heap_pages.
paging_init() initializes the machine_to_phys_mapping[] array, but its
called after end_boot_allocator().

As Keir said, there needs to be a more complete change for the
machine_to_phys_mapping[] array handling.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel