WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: xen boot crash

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: [Xen-devel] Re: xen boot crash
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Wed, 12 Jan 2011 11:01:41 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 12 Jan 2011 02:03:53 -0800
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1294826509; l=691; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=dyANHRg5WzpCOTRJ4YDbZEx7g+A=; b=JCRtoNhA1qhh/mHdvpEZVOlIjlzSrJARGBeYvY/hOeg+2syOvU3QakAQmHXKp8Oz8XP rEaSJ8tFbrE+vxsGHyG9WCz4FsmLwoguTDwIz3KGgZYAlKmq1Ud0I0RYFMH3blPV+rHVv GyTKkHnmcBX5xEuiaCq9Veeo0jDgFM/9lYI=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201101121045.06045.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201101121045.06045.Christoph.Egger@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Jan 12, Christoph Egger wrote:

> 
> Hi!
> 
> Changeset 22706:ca10302ac285  causes below boot crash.
> Reverting it makes xen boot again.
> 
> The rip points to xen/common/page_alloc.c:543

Yes, that change was not well done. Sorry for that. I'm sure it doesnt
crash if set_gpfn_from_mfn() is called from free_domheap_pages().

Looking at free_heap_pages(), now the page owner is cleared at the
beginning of the loop. But later in the loop it is checked wether a TLB
flush is required. So the set_gpfn_from_mfn() should be at least moved
past this check. Even if that doesnt fix the crash you are seening.

I will see if I can come up with a better version.


Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>