|
xen-devel
[Xen-devel] RE: [PATCH] mem_sharing: fix race condition of nominate and
|
To: |
<juihaochiang@xxxxxxxxx> |
|
Subject: |
[Xen-devel] RE: [PATCH] mem_sharing: fix race condition of nominate and unshare |
|
From: |
MaoXiaoyun <tinnycloud@xxxxxxxxxxx> |
|
Date: |
Tue, 11 Jan 2011 14:46:36 +0800 |
|
Cc: |
xen devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, tim.deegan@xxxxxxxxxx |
|
Delivery-date: |
Mon, 10 Jan 2011 22:47:36 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
Importance: |
Normal |
|
In-reply-to: |
<AANLkTin-2FDxeU+=RN0c0Bxqt8pYXw0r3Cv0csOcPNWQ@xxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<AANLkTinMp1v1zex2BfcUuszotPuxJFWZQNUp40gu_gxL@xxxxxxxxxxxxxx>, <20110106165450.GO21948@xxxxxxxxxxxxxxxxxxxxxxx>, <AANLkTinmpiusLqegGZA+bZWpDXPM+7Wq2nt8MZa0Ocet@xxxxxxxxxxxxxx>, <AANLkTinf-A_4NEPQeCw0pftM5Bks8BYPRhMx3-stTHxa@xxxxxxxxxxxxxx>, <20110107160949.GD5651@xxxxxxxxxxxxxxxxxxxxxxx>, <AANLkTikbQbRjmzbJ1g3QzYzLC-5ax9zhdYOKc2okt3bQ@xxxxxxxxxxxxxx>, <20110110103041.GE5651@xxxxxxxxxxxxxxxxxxxxxxx>, <BLU157-w33BF2EDA8572B8E418D084DA0F0@xxxxxxx>, <AANLkTin-2FDxeU+=RN0c0Bxqt8pYXw0r3Cv0csOcPNWQ@xxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Hi Jui_hao:
Page_make_private() --> page_set_owner(page, d) sets page owner when page_make_private success.
But in fact, I remember, when the Error log shows up, page_make_private failed, thus
page_set_owner(page, d) is not called.
> Date: Tue, 11 Jan 2011 14:32:51 +0800
> Subject: Re: [PATCH] mem_sharing: fix race condition of nominate and unshare
> From: juihaochiang@xxxxxxxxx
> To: tinnycloud@xxxxxxxxxxx
> CC: tim.deegan@xxxxxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxx
>
> Hi, all:
>
> I disable Rich formatting in gmail, does the format looks good now?
> To tinnycloud: hvm_hap_nested_page_fault() will be called when a guest
> writes a shared page.
>
> 2011/1/11 MaoXiaoyun <tinnycloud@xxxxxxxxxxx>
> >
> > Hi Tim:
> >
> > Sorry for the inconvenience, I think it's better now when I reply directly from hotmail.
> >
> > It looks like when unshare(), page_set_owner is forgetten, right?
>
> Inside unshare(), it does the following
> (1) page_make_private() --> page_set_owner(page, d
) to update
> page_info structure. So there is no need for you to add page_set_owner
> explicitly.
> (2) set_shared_p2m_entry() to update the page table
> From your log file, the page_make_private() is not called/executed
> properly. Could you debug into it also?
>
> Thanks,
> Jui-Hao
|
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home