WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] mem_sharing: fix race condition of nominate and

To: MaoXiaoyun <tinnycloud@xxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] mem_sharing: fix race condition of nominate and unshare
From: Jui-Hao Chiang <juihaochiang@xxxxxxxxx>
Date: Tue, 11 Jan 2011 14:32:51 +0800
Cc: xen devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, tim.deegan@xxxxxxxxxx
Delivery-date: Mon, 10 Jan 2011 22:33:45 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=7He2setaON2asetnwvSvc87ouB1lS7OBDBSyg9YHiHY=; b=fNzHcYkLMHI51pAB8SbBn9BFl7jnX6ZSG8Avqp2iH1G9WuFbmQftr2Fpktc4RiyCQl ghm1TDqC78PLr1Zgjy1Ee756CAyKe5MOtACa5fiy2sqrPdeAjHl22zKUZBB6LimKKNkR LbC2RSsnQUfLiNvLAmzGkuQf4ak91ir+C3EHw=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=b0A0lV/dZs/mNFjZ2Ar9Jb5UsHsgDJ4U/kvZx16VeIeSyj4cdwIlx69EcIuZcFNpUI F5HZcGbnwcznYe37VtLy0aOgK/UiXJDYcfrzeiP7UMvixWwKS0bdeCLb4o7mxZOZ2NHC gPXAj79f9A2WxLR+06hY9sH45vi0aNeJNvBjY=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <BLU157-w33BF2EDA8572B8E418D084DA0F0@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AANLkTinMp1v1zex2BfcUuszotPuxJFWZQNUp40gu_gxL@xxxxxxxxxxxxxx> <20110106165450.GO21948@xxxxxxxxxxxxxxxxxxxxxxx> <AANLkTinmpiusLqegGZA+bZWpDXPM+7Wq2nt8MZa0Ocet@xxxxxxxxxxxxxx> <AANLkTinf-A_4NEPQeCw0pftM5Bks8BYPRhMx3-stTHxa@xxxxxxxxxxxxxx> <20110107160949.GD5651@xxxxxxxxxxxxxxxxxxxxxxx> <AANLkTikbQbRjmzbJ1g3QzYzLC-5ax9zhdYOKc2okt3bQ@xxxxxxxxxxxxxx> <20110110103041.GE5651@xxxxxxxxxxxxxxxxxxxxxxx> <BLU157-w33BF2EDA8572B8E418D084DA0F0@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi, all:

I disable Rich formatting in gmail, does the format looks good now?
To tinnycloud: hvm_hap_nested_page_fault() will be called when a guest
writes a shared page.

2011/1/11 MaoXiaoyun <tinnycloud@xxxxxxxxxxx>
>
> Hi Tim:
>
>       Sorry for the inconvenience, I think it's better now when I reply 
> directly from hotmail.
>
>       It looks like when unshare(), page_set_owner is forgetten, right?

Inside unshare(), it does the following
(1) page_make_private() --> page_set_owner(page, d) to update
page_info structure. So there is no need for you to add page_set_owner
explicitly.
(2) set_shared_p2m_entry() to update the page table
>From your log file, the page_make_private() is not called/executed
properly. Could you debug into it also?

Thanks,
Jui-Hao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>