WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] pvops: fix "xm save -c" issue

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] pvops: fix "xm save -c" issue
From: Kenji Wakamiya <wkenji@xxxxxxxxxxxxxx>
Date: Thu, 16 Dec 2010 14:49:54 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 15 Dec 2010 21:50:47 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101215154021.GB28984@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D070138.7090708@xxxxxxxxxxxxxx> <20101214145925.GA5769@xxxxxxxxxxxx> <4D08417E.7060104@xxxxxxxxxxxxxx> <20101215154021.GB28984@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.24 (Windows/20100228)
Hi Konrad,

Konrad Rzeszutek Wilk wrote:
When the guest is unapused, stop_machine() in manage.c returns as the
suspend is cancelled. In that case, I think dpm_resume_end() should
not be called after stop_machine().

I tested vbd and net, the guest did not hang.

OK. Does 'xm save' (so no -c) and then resume work with this patch
(I would think so, but I am curious whether you tested this).

But I'm not sure if this is a right way...

Looks OK to me, just want to make sure that the normal 'xm save' still
works after this.

I tested normal 'xm save' with this patch, and made sure it works well.

When normal save/restore is performed, the domain is suspended without
cancel, unlike 'save -c'. So, dpm_resume_end() is called. This
scenario haven't changed even after applying this patch.

Thanks,
--
Kenji Wakamiya



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel