Re: [Xen-devel] [PATCH] pvops: fix "xm save -c" issue

[Kenji Wakamiya <wkenji@xxxxxxxxxxxxxx>]

Hi Konrad, thank you for your response,

Konrad Rzeszutek Wilk wrote:
> On Tue, Dec 14, 2010 at 02:31:36PM +0900, Kenji Wakamiya wrote:
> > Hi,
> >
> > I'm investigating the issue of "xm save -c" in case of PV guests.
> > Then, I tried to prevent calling dpm_resume_end() when suspend was
> > canceled. It seems to work fine about blk and net.
> > How about this?
> Could you give more details of what the failure is?
"xm save -c" saves domain state to storage and leaves it running after
creating snapshot. When this command is executed for a pvops
guest (xen/stable-2.6.32.x), the guest will hang up after accessing to
devices.

When the guest is unapused, stop_machine() in manage.c returns as the
suspend is cancelled. In that case, I think dpm_resume_end() should
not be called after stop_machine().

I tested vbd and net, the guest did not hang.
But I'm not sure if this is a right way...

Thanks,

> > Thanks,
> >
> > Signed-off-by: Kenji Wakamiya <wkenji@xxxxxxxxxxxxxx>
> > Signed-off-by: Kazuhiro Suzuki <kaz@xxxxxxxxxxxxxx>
> > --
> > Kenji Wakamiya
> > diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
> > index 0b50906..3dcc270 100644
> > --- a/drivers/xen/manage.c
> > +++ b/drivers/xen/manage.c
> > @@ -148,11 +148,10 @@ out_resume:
> >         if (!cancelled) {
> >                 xen_arch_resume();
> >                 xs_resume();
> > +               dpm_resume_end(PMSG_RESUME);
> >         } else
> >                 xs_suspend_cancel();
> >  
> > -	dpm_resume_end(PMSG_RESUME);
> > -
> >         /* Make sure timer events get retriggered on all CPUs */
> >         clock_was_set();
> >  
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel