WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Qemu-devel] [PATCH V6 04/15] Introduce -accel command o

To: Alexander Graf <agraf@xxxxxxx>
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH V6 04/15] Introduce -accel command option.
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Mon, 15 Nov 2010 13:56:31 +0100
Cc: Anthony.Perard@xxxxxxxxxx, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, QEMU-devel Developers <qemu-devel@xxxxxxxxxx>, Anthony Liguori <anthony@xxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Mon, 15 Nov 2010 04:57:31 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=GjUZ/Pxf3ZZ4yTeRsWjSJNw2MxyMnEGY1Nc6JXSBJIc=; b=Z/0+Fhh1PjFJrllAIr2nTYVByxZcxLLzFxmNXiqBZ+L0azIFPgw/JEpwFsqknPMHpg SSN91tOWMDKcIqa7Ehbjvcj+0xrSNEJcRdo0wroLD+Hs6658DmdOkpWfVZs0GH5DYIWz CdflySp45rrg4aKx8x8i/9Hif6PhcMhn/dVQE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=kdi+kDDVhmqyryXeQNQQZsC/BNeka35Jylv790h1eq3gw4aKs9ZS41M/rQqL/jw5cl Hv6GkCjmu4o8ZgOwWVgE3ckP2EkhqtzTGYhSSwpHK42LRey1OJZZEz0dAdPkeuiLAG9u JSYbcAaBiqlQvD8jEZpEBq42MIyxvLnZoRcjM=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C0AD410B-E24A-43B5-93A9-6B41D4CEEC93@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1287682587-18642-1-git-send-email-anthony.perard@xxxxxxxxxx> <1287682587-18642-5-git-send-email-anthony.perard@xxxxxxxxxx> <C0AD410B-E24A-43B5-93A9-6B41D4CEEC93@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Fedora/3.1.6-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6
On 11/15/2010 11:46 AM, Alexander Graf wrote:
I take back my Acked-by. Sorry, I guess I should have read things in
more detail first O_o. I still believe that this patch can go in
before the others, but I'd at least like to see some comments on the
(0) pointer thing:).

I agree, it kind of works by chance, (0) works but (1) wouldn't. Better to define the function always.

Paolo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel