WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] amd iommu: Fix HV crach with 32bit pv_ops kernel

To: "Wei Wang2" <wei.wang2@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] amd iommu: Fix HV crach with 32bit pv_ops kernel
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Mon, 15 Nov 2010 12:37:27 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Mon, 15 Nov 2010 04:38:29 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201011151118.40873.wei.wang2@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201011151118.40873.wei.wang2@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> On 15.11.10 at 11:18, Wei Wang2 <wei.wang2@xxxxxxx> wrote:
>--- a/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h    Wed Nov 10 14:56:06 
>2010 +0000
>+++ b/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h    Fri Nov 12 17:10:31 
>2010 +0100
>@@ -31,8 +31,8 @@
> 
> #define DMA_32BIT_MASK  0x00000000ffffffffULL
> 
>-extern int amd_iommu_debug;
>-extern int amd_iommu_perdev_intremap;
>+extern bool_t amd_iommu_debug;
>+extern bool_t amd_iommu_perdev_intremap;
> 
> #define AMD_IOMMU_DEBUG(fmt, args...) \
>     do  \

This surely can't be complete: If you had a type mismatch between
declaration and definition, the defining code is clearly missing an
#include of the #define-ing header.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel