Re: [Xen-devel] [PATCH] refetch qemu if QEMU_TAG changed

[Brendan Cully <brendan@xxxxxxxxx>]

On Friday, 29 October 2010 at 08:20, Ian Campbell wrote:
> On Fri, 2010-10-29 at 07:57 +0100, Juergen Gross wrote:
> > Check for a changed QEMU_TAG. If it has changed since last build, delete old
> > qemu sources and refetch with new QEMU_TAG.
> 
> Deleteing and recloning seems like an awfully big hammer. Can the same
> not be achieved with a "git fetch origin" and a "git reset <tag>"?

In any case, it should probably only do that if the currently
checked-out version matches the old value of QEMU_TAG and the
directory has no source modifications, indicating the builder is just
using the default build. Otherwise it should just warn that QEMU_TAG
has changed and the ioemu directory may have become out of date.

With the proposed patch it's very easy to destroy a developer's code.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel