On Mon, Oct 25, 2010 at 02:47:56PM -0400, Christoph Hellwig wrote:
> On Mon, Oct 25, 2010 at 02:26:30PM -0400, Konrad Rzeszutek Wilk wrote:
> > I think we just blindly assume that we would pass the request
> > to the backend. And if the backend is running under an ancient
> > version (2.6.18), the behavior would be quite different.
>
> I don't think this has much to do with the backend. Xen never
> implemented empty barriers correctly. This has been a bug since day
> one, although before no one noticed because the cruft in the old
> barrier code made them look like they succeed without them actually
> succeeding. With the new barrier code you do get an error back for
> them - and you do get them more often because cache flushes aka
> empty barriers are the only thing we send now.
>
> The right fix is to add a cache flush command to the protocol which
> will do the right things for all guests. In fact I read on a netbsd
> lists they had to do exactly that command to get their cache flushes
> to work, so it must exist for some versions of the backends.
Ok, thank you for the pointer.
Daniel, you are the resident expert, what do you say?
Jens, for 2.6.37 is the patch for disabling write barrier support
by the xen-blkfront the way to do it?
Or if we came up with a patch now would it potentially make it in
2.6.37-rcX (I don't know if the fix for this would qualify as a bug
or regression since it looks to be adding a new command)? And what
Christoph suggest that this has been in v2.6.36, v2.6.35, etc. so that
would definitly but it outside the regression definition.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home