WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 06/18] xenpaging: allow only one xenpaging binary

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 06/18] xenpaging: allow only one xenpaging binary per guest
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Mon, 18 Oct 2010 19:04:06 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 18 Oct 2010 10:05:33 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1287421454; l=1238; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=OehtUPYjLlYQ+/KlwvLKCZNFfuY=; b=vWIr4urUX+LKzX68rK9IreOA1l8/KYztE0MSVLvU0bTTtGav6agDP4pxIRpoKK+fHXO wvm5XwdN9NdeHLsvQVE4TUXBfqMOFIlpVvLM8s2suZ8468r4oEc0qyiPcz6bRA5WHIsYL IqdFs7Irj3SfAFTf8963vuQmBCSMQ6mkbmg=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19644.31701.346075.873651@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20101015141202.309585877@xxxxxxxxx> <20101015141204.419704862@xxxxxxxxx> <19644.31701.346075.873651@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Oct 18, Ian Jackson wrote:

> Olaf Hering writes ("[Xen-devel] [PATCH 06/18] xenpaging: allow only one 
> xenpaging binary per guest"):
> > -        ERROR("Error initialising shared page");
> > +        switch ( errno ) {
> > +            case EBUSY:
> > +                ERROR("xenpaging is (or was) active on this domain");
> > +                break;
> > +            case ENODEV:
> > +                ERROR("EPT not supported for this guest");
> > +                break;
> > +            default:
> > +                ERROR("Error initialising shared page");
> > +                break;
> 
> Surely this should print the actual errno value.

Ok, can be done.

> > +            /* Only one xenpaging at a time. If xenpaging crashed,
> > +             * the cache is in an undefined state and so is the guest
> > +             */
> > +            rc = -EBUSY;
> > +            if ( d->mem_event.enabled )
> > +                break;
> 
> Is there any way to recover from this or is the guest just hosed ?

If xenpaging dies for some reason, the bitmap which maps the "pageslot"
in the pagefile to the gfn in the guest is gone. There is no way to
recover from this situation. If the paging state should be persistant,
then the maintained bitmaps have to be kept in memory and each page write
has to be fsynced in some way.
Some other way has to be found to prevent two xenpaging runs per
domain_id.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>