WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 06/18] xenpaging: allow only one xenpaging binary

To: Olaf Hering <olaf@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 06/18] xenpaging: allow only one xenpaging binary per guest
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 18 Oct 2010 17:54:45 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 18 Oct 2010 09:55:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101015141204.419704862@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <20101015141202.309585877@xxxxxxxxx> <20101015141204.419704862@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Olaf Hering writes ("[Xen-devel] [PATCH 06/18] xenpaging: allow only one 
xenpaging binary per guest"):
> -        ERROR("Error initialising shared page");
> +        switch ( errno ) {
> +            case EBUSY:
> +                ERROR("xenpaging is (or was) active on this domain");
> +                break;
> +            case ENODEV:
> +                ERROR("EPT not supported for this guest");
> +                break;
> +            default:
> +                ERROR("Error initialising shared page");
> +                break;

Surely this should print the actual errno value.

> +            /* Only one xenpaging at a time. If xenpaging crashed,
> +             * the cache is in an undefined state and so is the guest
> +             */
> +            rc = -EBUSY;
> +            if ( d->mem_event.enabled )
> +                break;

Is there any way to recover from this or is the guest just hosed ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>