xen-devel

[Top] [All Lists]

[Xen-devel] Re: [PATCH] x86: don't use mcount in pvclock.c

from [Steven Rostedt]

[Permanent Link][Original]

To:	Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject:	[Xen-devel] Re: [PATCH] x86: don't use mcount in pvclock.c
From:	Steven Rostedt <rostedt@xxxxxxxxxxx>
Date:	Wed, 22 Sep 2010 20:34:39 -0400
Cc:	"Xen-devel@xxxxxxxxxxxxxxxxxxx" <Xen-devel@xxxxxxxxxxxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
Delivery-date:	Wed, 22 Sep 2010 17:35:54 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4C9A9A3F.4040201@xxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<4C9A9A3F.4040201@xxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Crap!

I fixed this back on 7/1/2010 from a RHEL bugzilla report, and forgot to
push it mainline. This also requires kvmclock.o to have the -pg as well.

I'll add your patch and add the kvmclock.o too.

Thanks,

-- Steve


On Wed, 2010-09-22 at 17:07 -0700, Jeremy Fitzhardinge wrote:
> 
> When using a paravirt clock, pvclock.c can be used by sched_clock(),
> which in turn is used by the tracing mechanism for timestamps,
> which leads to infinite recursion.
> 
> Disable mcount/tracing for pvclock.o.
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> 
> diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
> index f3477bb..35b447c 100644
> --- a/arch/x86/kernel/Makefile
> +++ b/arch/x86/kernel/Makefile
> @@ -11,6 +11,7 @@ ifdef CONFIG_FUNCTION_TRACER
>  CFLAGS_REMOVE_tsc.o = -pg
>  CFLAGS_REMOVE_rtc.o = -pg
>  CFLAGS_REMOVE_paravirt-spinlocks.o = -pg
> +CFLAGS_REMOVE_pvclock.o = -pg
>  CFLAGS_REMOVE_ftrace.o = -pg
>  CFLAGS_REMOVE_early_printk.o = -pg
>  endif
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] x86: don't use mcount in pvclock.c, Jeremy Fitzhardinge [Xen-devel] Re: [PATCH] x86: don't use mcount in pvclock.c, Steven Rostedt <=

Previous by Date:	[Xen-devel] Re: 25% cpu usage during idle, Jeremy Fitzhardinge
Next by Date:	RE: [Xen-devel] Re: VM hung after running sometime, MaoXiaoyun
Previous by Thread:	[Xen-devel] [PATCH] x86: don't use mcount in pvclock.c, Jeremy Fitzhardinge
Next by Thread:	[Xen-devel] Re: 25% cpu usage during idle, Jeremy Fitzhardinge
Indexes:	[Date] [Thread] [Top] [All Lists]