On Wed, 2010-09-15 at 09:45 +0100, Juergen Gross wrote:
> On 09/15/10 10:29, Ian Campbell wrote:
> > On Wed, 2010-09-15 at 08:26 +0100, Juergen Gross wrote:
> >> diff -r 3985fea87987 tools/libxl/libxl.idl
> >> --- a/tools/libxl/libxl.idl Fri Sep 10 19:06:33 2010 +0100
> >> +++ b/tools/libxl/libxl.idl Wed Sep 15 09:19:02 2010 +0200
> >> @@ -43,7 +43,11 @@ SHUTDOWN_* constant."""),
> >> ], destructor_fn=None)
> >>
> >> libxl_poolinfo = Struct("poolinfo", [
> >> - ("poolid", uint32)
> >> + ("poolid", uint32),
> >> + ("sched_id", uint32),
> >> + ("n_dom", uint32),
> >> + ("cpumap_size", uint32),
> >> + ("cpumap", libxl_cpumap)
> >> ], destructor_fn=None)
> >>
> >> libxl_vminfo = Struct("vminfo", [
> >
> > Does the addition of the cpumap field here mean that we now need to
> > generate a destructor function (by removing destructor_fn=None) and call
> > it e.g. from main_pool*?
>
> I took care of this by allocating the space for the cpumap(s) together with
> the poolinfo structure(s).
> If you don't like this, a destructor would be the correct solution, I think.
Personally I would prefer using the destructor style for consistency
with other libxl types.
> I'll update the patch. It would be nice to know whether you are planning to
> change libxl_cpumap to include the size or not.
I wasn't immediately planning on it but I can if you don't want to do it
as part of this patchset.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home