WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch][resend] implementation of cpupool support in xl

To: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch][resend] implementation of cpupool support in xl
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Wed, 15 Sep 2010 09:29:11 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 15 Sep 2010 01:30:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C907510.3070904@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <4C907510.3070904@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2010-09-15 at 08:26 +0100, Juergen Gross wrote:
> diff -r 3985fea87987 tools/libxl/libxl.idl
> --- a/tools/libxl/libxl.idl     Fri Sep 10 19:06:33 2010 +0100
> +++ b/tools/libxl/libxl.idl     Wed Sep 15 09:19:02 2010 +0200
> @@ -43,7 +43,11 @@ SHUTDOWN_* constant."""),
>      ], destructor_fn=None)
>  
>  libxl_poolinfo = Struct("poolinfo", [
> -    ("poolid", uint32)
> +    ("poolid",      uint32),
> +    ("sched_id",    uint32),
> +    ("n_dom",       uint32),
> +    ("cpumap_size", uint32),
> +    ("cpumap",      libxl_cpumap)
>      ], destructor_fn=None)
>  
>  libxl_vminfo = Struct("vminfo", [ 

Does the addition of the cpumap field here mean that we now need to
generate a destructor function (by removing destructor_fn=None) and call
it e.g. from main_pool*?

Would it make sense to turn libxl_cpumap into a struct containing both
the size and the data pointer?

> diff -r 3985fea87987 tools/libxl/libxl.h
> --- a/tools/libxl/libxl.h     Fri Sep 10 19:06:33 2010 +0100
> +++ b/tools/libxl/libxl.h     Wed Sep 15 09:19:02 2010 +0200
> @@ -471,6 +471,15 @@ int libxl_device_net2_del(libxl_ctx *ctx
>  int libxl_device_net2_del(libxl_ctx *ctx, libxl_device_net2 *net2,
>                            int wait);
>  
> +int libxl_get_freecpus(libxl_ctx *ctx, int *n_cpus, uint64_t **cpumap);
> +int libxl_create_cpupool(libxl_ctx *ctx, char *name, int schedid,
> +                         uint64_t *cpumap, int n_cpus, libxl_uuid *uuid,
> +                         uint32_t *poolid);

Should these cpumap parameters be libxl_cpumap* or are they a different sort of 
cpumap?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel