Re: [Xen-devel] possible code/comment mismatch in hap_enable_vra

At 14:37 +0100 on 09 Sep (1284043066), Olaf Hering wrote:
> 
> Hello,
> 
> the comments in hap_enable_vram_tracking() and hap_clean_vram_tracking()
> say the pages will be set to read-only, but it passes p2m_ram_rw instead
> of p2m_ram_ro to p2m_change_type().
> 
> Bug or feature?

Neither. :)  It's changing _from_ type p2m_ram_rw to type p2m_ram_logdirty
(which is read-only until the next write, when it reverts to p2m_ram_rw
and marks the page dirty).

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] possible code/comment mismatch in hap_enable_vram_tracking/hap_clean_vram_tracking, Olaf Hering Re: [Xen-devel] possible code/comment mismatch in hap_enable_vram_tracking/hap_clean_vram_tracking, Tim Deegan <=

Previous by Date:

[Xen-devel] Re: [PATCH]: change libxl IDL to export a saner interface for upcoming language bindings, Gianni Tedesco

Next by Date:

[Xen-devel] Re: [PATCH 13/13] Nested Virtualiztion: hap-on-hap, Christoph Egger

Previous by Thread:

[Xen-devel] possible code/comment mismatch in hap_enable_vram_tracking/hap_clean_vram_tracking, Olaf Hering

Next by Thread:

[Xen-devel] Linux device naming (suggested udev rules adjustment), Jan Beulich

Indexes:

[Date] [Thread] [Top] [All Lists]