WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] possible code/comment mismatch in hap_enable_vram_tracking/h

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] possible code/comment mismatch in hap_enable_vram_tracking/hap_clean_vram_tracking
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Thu, 9 Sep 2010 15:37:46 +0200
Delivery-date: Thu, 09 Sep 2010 06:39:38 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1284039470; l=224; s=domk; d=aepfle.de; h=Content-Type:MIME-Version:Subject:To:From:Date:X-RZG-CLASS-ID: X-RZG-AUTH; bh=oRLraBL/O8NxS+Nw9F0TssK2Mfc=; b=JlbJclsjdeVkDsubSM2QyTlpKYZdL9c73j/CnDVFBOlGnjre17/8uyvaEDW4qmLo0pk Z+maAYpDuPQT+ecG0+6VPIa3YR1spEqxOKiczgzD7vQjqZ90Z4dnwZ6N9pP+h46Et2v4D X9uepMiB17C1mn2ApcIqRBRju7yEUSKCxP4=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
Hello,

the comments in hap_enable_vram_tracking() and hap_clean_vram_tracking()
say the pages will be set to read-only, but it passes p2m_ram_rw instead
of p2m_ram_ro to p2m_change_type().

Bug or feature?

Olaf


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>