Re: [Xen-devel] Xen-unstable panic: FATAL PAGE FAULT

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 01/09/2010 10:01, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>>>> On 01.09.10 at 10:49, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> wrote:
>> Okay, my next guess then is that we are deleting a chunk from the wrong list
>> head. I don't see any check that the adjacent chunks we are considering to
>> merge are from the same node and zone. I suppose the zone logic does just
>> work as we're dealing with 2**x aligned and sized regions. But, shouldn't
>> the merging logic in free_heap_pages be checking that the merging candidate
>> is from the same NUMA node? I see I have an ASSERTion later in the same
>> function, but it's too weak and wishful I suspect.
> 
> Hmm, we're keeping a page reserved if node boundaries aren't
> well aligned (at the end of init_heap_pages()), so that shouldn't
> be possible.

Oh yes, that ought to be sufficient really.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel