WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 3 of 3] Centralize parsing of PCI BDF's in xl

To: "Gianni Tedesco (3P)" <gianni.tedesco@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 3 of 3] Centralize parsing of PCI BDF's in xl
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Thu, 29 Jul 2010 15:42:02 +0100
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, Stefano
Delivery-date: Thu, 29 Jul 2010 07:41:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <e49597460a1ac37e4ac3.1280346051@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1280346048@xxxxxxxxxxxxxxxxxxxxxx> <e49597460a1ac37e4ac3.1280346051@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Wed, 28 Jul 2010, Gianni Tedesco (3P) wrote:
>  tools/libxl/libxl.h      |   6 +---
>  tools/libxl/libxl_pci.c  |  71 
> +++++++++++++++++++++++++++++++++++++----------
>  tools/libxl/xl_cmdimpl.c |  46 ++++--------------------------
>  3 files changed, 64 insertions(+), 59 deletions(-)
> 
> 
> Introduce a new libxl call libxl_device_pci_parse_bdf() and use it
> consistently.
> 
> This patch also fixes an infinite loop bug in xl create. If there is a
> parse-error on any pci config file entry then xl will attempt to skip it, but
> since num_pcidevs is used to index the config list and is not incremented when
> skipping, this caused an infinite loop. Solve that problem by introducing a 
> new
> loop counter variable.
> 
> Note that virtual PCI slots are not parsed by the new code. However this is
> a step towards support for virtual slots and multi-function device assignment
> since only one location in the code will need to be changed now.
> 
> Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
> 


Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>