|
|
|
|
|
|
|
|
|
|
xen-devel
[Xen-devel] Re: [PATCH 1/4] irq: rename IRQF_TIMER to IRQF_NO_SUSPEND
To: |
Ian Campbell <ian.campbell@xxxxxxxxxx> |
Subject: |
[Xen-devel] Re: [PATCH 1/4] irq: rename IRQF_TIMER to IRQF_NO_SUSPEND |
From: |
Thomas Gleixner <tglx@xxxxxxxxxxxxx> |
Date: |
Thu, 29 Jul 2010 10:49:21 +0200 (CEST) |
Cc: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, devicetree-discuss@xxxxxxxxxxxxxxxx, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Grant Likely <grant.likely@xxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxx, Paul Mackerras <paulus@xxxxxxxxx>, linux-input@xxxxxxxxxxxxxxx |
Delivery-date: |
Thu, 29 Jul 2010 01:50:30 -0700 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<1280314467-5637-1-git-send-email-ian.campbell@xxxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
References: |
<1280314445.24292.90.camel@xxxxxxxxxxxxxxxxxxxxxx> <1280314467-5637-1-git-send-email-ian.campbell@xxxxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
User-agent: |
Alpine 2.00 (LFD 1167 2008-08-23) |
On Wed, 28 Jul 2010, Ian Campbell wrote:
> Continue to provide IRQF_TIMER as an alias to IRQF_NO_SUSPEND since I
> think it is worth preserving the nice self-documenting name (where it
> is used appropriately). It also avoid needing to patch all the many
> users who are using the flag for an actual timer interrupt.
I'm not happy about the alias. What about:
#define __IRQF_TIMER 0x00000200
#define IRQF_NO_SUSPEND 0x00000400
#define IRQF_TIMER (__IRQF_TIMER | IRQF_NO_SUSPEND)
Thanks,
tglx
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|