Re: [Xen-devel] [PATCH 1 of 3] xenpaging: Add a check to Xen for EPT

[Patrick Colp <pjcolp@xxxxxxxxx>]

ENOSYS tends to be used to indicate an invalid/unsupported domctl. I
chose ENODEV as an alternative so that it provides a unique error
return code and seemed relatively sane (vs say something like E2BIG).
I'm not particularly fussed about what the actually error code is, I
just wanted it to be able to distinguish a lack-of-EPT-support error
from other errors (the other error codes in use in the mem-event
enable domctl are ENOSYS and EINVAL). If you have a suggestion for
another one to use, I'm happy to hear it.


Patrick


On 28 July 2010 09:59, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> I wrote:
>> I haven't tested this but this and the corresponding patch 2/3 to
>> produce a better error message look sane.  [...]
>
> I meant 3/3.  I have some comments on 2/3.
>
> Ian.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel