Re: [Xen-devel] [PATCH 2 of 3] xenpaging: Fix-up xenpaging tool code

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Patrick Colp writes ("[Xen-devel] [PATCH 2 of 3] xenpaging: Fix-up xenpaging 
tool code"):
>   err:
> -    if ( paging->bitmap )
> -        free(paging->bitmap);
> -    if ( paging->platform_info )
> -        free(paging->platform_info);
>      if ( paging )
> +    {
> +        if ( paging->bitmap )
> +            free(paging->bitmap);

While you're doing this, why not replace

>-+        if ( paging->bitmap )
>-+            free(paging->bitmap);
with

>++        free(paging->bitmap);

since free(0) is legal and a no-op ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel