Re: [Xen-devel] [PATCH] libxl: blktap2 portiblity fixes

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH] libxl: blktap2 portiblity fixes"):
> On Mon, 2010-07-26 at 15:53 +0100, Ian Jackson wrote:
> >   * Code motion between files, and creation of libxl_linux.c;
> >   * Provide libxl_netbsd.c and associated Makefile changes to
> >     disable blktap2 on netbsd 
> 
> I wonder if this might be better as libxl_blk_blktap.c and
> libxl_blk_none.c or something to correspond to the presence of the
> specific feature rather than an OS which happens to implement the
> feature?

Good point.

> (I guess in this specific instance the chances of blktap
> cropping up on another OS is pretty slim).

Well, but there's no harm to naming the feature rather than the
platform.  It's good practice.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel