WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] libxl: blktap2 portiblity fixes

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxl: blktap2 portiblity fixes
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Fri, 23 Jul 2010 13:30:06 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 23 Jul 2010 05:30:57 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201007211032.28235.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201007201831.21416.Christoph.Egger@xxxxxxx> <alpine.DEB.2.00.1007201745480.22235@kaball-desktop> <201007211032.28235.Christoph.Egger@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Wed, 21 Jul 2010, Christoph Egger wrote:
> On Tuesday 20 July 2010 18:46:30 Stefano Stabellini wrote:
> > On Tue, 20 Jul 2010, Christoph Egger wrote:
> > > Hi!
> > >
> > > Attached patch moves blktap2 (which is Linux specific) into
> > > a linux specific file.
> > > Combined with the previous libxl patch, libxl builds again on NetBSD.
> > >
> > > Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> >
> > this patch breaks the build:
> >
> > libxenlight.so: undefined reference to `libxl_blktap_enabled'
> > libxenlight.so: undefined reference to `libxl_blktap_devpath'
> > collect2: ld returned 1 exit status
> 
> Oh, I see the problem. The wrong lines are those:
> 
> LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o
> +LIBXL_OBJS-$(CONFIG_Linux) = libxl_linux.o
> +LIBXL_OBJS-$(CONFIG_NetBSD) = libxl_netbsd.o
> 
> New corrected version is attached. It also reverts
> c/s 21835 as this showed up due to this bug in my tree.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> 

This seems to be the right fix for the compiling issue.
Acked by me.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel