WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [PATCH] Re: [Xen-devel] New release candidate for Xen 4.0.1

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Re: [Xen-devel] New release candidate for Xen 4.0.1
From: M A Young <m.a.young@xxxxxxxxxxxx>
Date: Wed, 21 Jul 2010 13:08:09 +0100 (BST)
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 21 Jul 2010 05:09:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1007211251310.22235@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.LFD.2.00.1007201858050.19930@xxxxxxxxxxxxxxx> <alpine.DEB.2.00.1007211251310.22235@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (GSO 1167 2008-08-23)
On Wed, 21 Jul 2010, Stefano Stabellini wrote:

I would rather backport this to xen4.0:


# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1276064492 -3600
# Node ID 0c10e80e083b115313bfc213e7683f4fc3f761bc
# Parent  87fe942a90b1d96b5e378fa5b221fd8eeba439da
tools: fix install bash-completion files to non-default locations.

Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

diff -r 87fe942a90b1 -r 0c10e80e083b Config.mk
--- a/Config.mk Wed Jun 09 07:18:30 2010 +0100
+++ b/Config.mk Wed Jun 09 07:21:32 2010 +0100
@@ -29,7 +29,7 @@ include $(XEN_ROOT)/config/$(XEN_TARGET_
SHAREDIR    ?= $(PREFIX)/share
DOCDIR      ?= $(SHAREDIR)/doc/xen
MANDIR      ?= $(SHAREDIR)/man
-BASH_COMPLETION_DIR ?= /etc/bash_completion.d
+BASH_COMPLETION_DIR ?= $(CONFIG_DIR)/bash_completion.d

ifneq ($(EXTRA_PREFIX),)
EXTRA_INCLUDES += $(EXTRA_PREFIX)/include


Adding that line at that place looks reasonable, though that patch won't work because there isn't currently a BASH_COMPLETION_DIR line in Config.mk, hence the original bug. It looks like the selective backport
http://xenbits.xensource.com/xen-4.0-testing.hg?rev/b1321a50f626
of xl stuff missed this.

        Michael Young

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel