Re: [PATCH] Re: [Xen-devel] New release candidate for Xen 4.0.1

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 20 Jul 2010, M A Young wrote:
> I have a minor fix for this. BASH_COMPLETION_DIR is used uninitialized in 
> tools/libxl/Makefile which means that xl.sh can end up in / which is not 
> ideal. 
> The patch below sets a sensible default for this variable.
> 
> Signed-off-by: Michael Young <m.a.young@xxxxxxxxxxxx>
> 
> --- xen-4.0.1/tools/libxl/Makefile.orig       2010-07-16 18:27:14.000000000 
> +0100
> +++ xen-4.0.1/tools/libxl/Makefile    2010-07-16 19:39:46.000000000 +0100
> @@ -4,6 +4,7 @@
> 
>   XEN_ROOT = ../..
>   include $(XEN_ROOT)/tools/Rules.mk
> +BASH_COMPLETION_DIR ?= /etc/bash_completion.d/
> 
>   MAJOR = 1.0
>   MINOR = 0
> 

I would rather backport this to xen4.0:


# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1276064492 -3600
# Node ID 0c10e80e083b115313bfc213e7683f4fc3f761bc
# Parent  87fe942a90b1d96b5e378fa5b221fd8eeba439da
tools: fix install bash-completion files to non-default locations.

Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

diff -r 87fe942a90b1 -r 0c10e80e083b Config.mk
--- a/Config.mk Wed Jun 09 07:18:30 2010 +0100
+++ b/Config.mk Wed Jun 09 07:21:32 2010 +0100
@@ -29,7 +29,7 @@ include $(XEN_ROOT)/config/$(XEN_TARGET_
 SHAREDIR    ?= $(PREFIX)/share
 DOCDIR      ?= $(SHAREDIR)/doc/xen
 MANDIR      ?= $(SHAREDIR)/man
-BASH_COMPLETION_DIR ?= /etc/bash_completion.d
+BASH_COMPLETION_DIR ?= $(CONFIG_DIR)/bash_completion.d
 
 ifneq ($(EXTRA_PREFIX),)
 EXTRA_INCLUDES += $(EXTRA_PREFIX)/include

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel